Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate documentation when Solve is called with both an initial guess and when MathematicalProgram Initial guess is set. #22252

Open
AlexandreAmice opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
component: mathematical program Formulating and solving mathematical programs; our autodiff and symbolic libraries good first issue Thinking of contributing? These issues might be a good place to start. type: feature request

Comments

@AlexandreAmice
Copy link
Contributor

In both SolverInterface::Solve and Solve in solver.h we are very clear that if a MathematicalProgram prog has a certain solver option foo set, and a passed SolverOption solver_option is passed with a different value for foo then the option passed in solver_option will be used.

However, no analogous documentation exists for what happens when the initial guess is set in both prog and passed as an initial guess. Based on our implementation of Solve in SolverBase, we use first the passed initial guess, then the program initial guess.

We should document and test this behavior if it is the expected behavior.

@AlexandreAmice AlexandreAmice added type: feature request good first issue Thinking of contributing? These issues might be a good place to start. labels Dec 2, 2024
@rpoyner-tri rpoyner-tri added the component: mathematical program Formulating and solving mathematical programs; our autodiff and symbolic libraries label Dec 3, 2024
@rpoyner-tri
Copy link
Contributor

Assigning to @hongkai-dai for further triage and delegation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: mathematical program Formulating and solving mathematical programs; our autodiff and symbolic libraries good first issue Thinking of contributing? These issues might be a good place to start. type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants