-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing mujoco equality connect constraints: default vs zero configuration #22462
Comments
having thought about it a bit today, I think a reasonable way forward would be to add one more optional argument to the |
My first idea was a plant-wide option that set's the "default" configuration mode, but I think per-constraint is a better idea. I still find the MuJoCo doc a bit confusing as written. Did you happen to find a section that would lead a user to the correct conclusion that "in the configuration in which the model is defined." means the zero configuration? I would assume that since the |
Hmm, also does it use the zero configuration when 0 is outside of the limits of a joint? I can't seem to find this information in the docs. |
WIP branch is here fyi: https://github.com/joemasterjohn/drake/tree/constraint_default_state_mode |
I agree that the docs are lacking on both points. The cassie model has been my verification. In that example, both the zero configuration and the default (because it's often zero) are actually outside of some joint limits. But using that zero position (no clamping to the limits) is the only way to make the linkage closed by obvious visual inspection. |
If it's feasible to either read (in code) or explore (with experiments) what Mujoco is actually doing, an ideal next step would be to open a pull request again their docs with a precise specification, which then we could check that both implementation adhere to. I seem to recall that @sherm1 did that for SDFormat specs many years back. Building multibody parsers around a solid, unambiguous specification is really the best option when feasible. Cross-checking with robot species is also helpful, but will be more brittle. |
What happened?
After testing more mujoco models with loop joints, it seems that #22446 actually made some of them worse. (even though I think that PR is implemented correctly)
The problem is, perhaps, a bit fundamental. To help parse mujoco constraints, we changed AddBallConstraint to allow
note the default configuration there.
In mujoco, the equality connect doc says
that's equivalent to our "zero" configuration, not our default configuration.
This breaks the cassie model in the mujoco menagerie.
Possible solutions:
@joemasterjohn and others -- wdyt?
Version
No response
What operating system are you using?
No response
What installation option are you using?
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: