chore(a11y): RoomInfoEditView #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtavioStasiak
changed the title
OtavioStasiak
force-pushed
the
chore-a11y-edit-room-info
branch
from
89929ad to
ce2d7c2
Compare
diegolmello
reviewed
Dec 9, 2024
| @@ -2,6 +2,7 @@ import { BottomSheetTextInput } from '@discord/bottom-sheet'; | |||
| import React, { useState } from 'react'; | |||
| import { StyleProp, StyleSheet, Text, TextInput as RNTextInput, TextInputProps, TextStyle, View, ViewStyle } from 'react-native'; | |||
| import Touchable from 'react-native-platform-touchable'; | |||
| import { A11y } from 'react-native-a11y-order'; | |||
There was a problem hiding this comment.
My concern about this lib is
Because of its native nature, it is important to wrap all components inside A11y.Order with A11y.Index. Components not wrapped in A11y.Index may be skipped from the reading order on iOS, or read at the end on Android. If you need to manage many elements, try to group them with a view and then control them via the ordering system. You can find an example below.
We would have to wrap the whole app on it.
There was a problem hiding this comment.
I tried to do it, but it does not work on iOS.
OtavioStasiak
force-pushed
the
chore-a11y-edit-room-info
branch
from
ab4e981 to
05dead4
Compare
diegolmello
requested changes
Jan 8, 2025
| @@ -167,7 +170,10 @@ export const FormTextInput = ({ | |||
| ) : null} | |||
|
|
|||
| {secureTextEntry ? ( | |||
| <Touchable onPress={() => setShowPassword(!showPassword)} style={[styles.iconContainer, styles.iconRight]}> | |||
| <Touchable | |||
There was a problem hiding this comment.
It rendering outside of TextInput
diegolmello
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added accessibility features to the RoomInfoEditView.
Issue(s)
https://rocketchat.atlassian.net/browse/MA-196
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments