Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stop removing commas from terminal output" #1240

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 27, 2025

Reverts #1228

Cursor is still on 1.96.2 and this is fixed in 1.97.2 😞


Important

Reverts change to remove commas from terminal output in TerminalProcess.ts due to version issue with Cursor.

  • Behavior:
    • Reverts change to stop removing commas from terminal output in TerminalProcess class in TerminalProcess.ts.
    • Reintroduces data = data.replace(/,/g, "") to remove commas from data chunks.
  • Reason:
    • Cursor is on version 1.96.2, and the issue is fixed in version 1.97.2.

This description was created by Ellipsis for dc83617. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from cte as a code owner February 27, 2025 14:51
Copy link

changeset-bot bot commented Feb 27, 2025

⚠️ No Changeset found

Latest commit: dc83617

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 27, 2025
@mrubens mrubens merged commit 5efb3c1 into main Feb 27, 2025
10 of 11 checks passed
@mrubens mrubens deleted the revert-1228-stop_removing_commas_from_terminal_output branch February 27, 2025 14:51
@cte
Copy link
Collaborator

cte commented Feb 27, 2025

@mrubens Is there way to conditionally apply this based on the VSCode version (not sure if it can easily be detected).

Also, curious if this impacts #1236.

@mrubens
Copy link
Collaborator Author

mrubens commented Feb 27, 2025

@mrubens Is there way to conditionally apply this based on the VSCode version (not sure if it can easily be detected).

Also, curious if this impacts #1236.

Good questions! Not sure about either.

@joemanley201
Copy link

@mrubens Is there way to conditionally apply this based on the VSCode version (not sure if it can easily be detected).
Also, curious if this impacts #1236.

Good questions! Not sure about either.

Screenshot 2025-02-27 at 11 05 01 AM

Maybe vscode.version can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants