Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stop removing commas from terminal output" #1240

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Revert "Stop removing commas from terminal output" #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/sour-parents-hug.md
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/integrations/terminal/TerminalProcess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ export class TerminalProcess extends EventEmitter<TerminalProcessEvents> {
data = lines.join("\n")
}

// FIXME: right now it seems that data chunks returned to us from the shell integration stream contains random commas, which from what I can tell is not the expected behavior. There has to be a better solution here than just removing all commas.
data = data.replace(/,/g, "")

// 2. Set isHot depending on the command
// Set to hot to stall API requests until terminal is cool again
this.isHot = true
Expand Down
Loading