[SAPBTPCFS-15469] Update Service Instance on change of 'parametersFro…

…m' secret
SAP · Dec 18, 2024 · 7aaf27d · 7aaf27d
1 parent ece2c30
commit 7aaf27d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/controllers/serviceinstance_controller.go b/controllers/serviceinstance_controller.go
@@ -567,10 +567,10 @@ func (r *ServiceInstanceReconciler) buildSMRequestParameters(ctx context.Context
 	//sync instance labels
 	for key, value := range serviceInstance.Labels {
 		if strings.HasPrefix(key, common.InstanceSecretRefLabel) {
-			if secretName, ok := instanceLabels[key]; !ok {
+			if _, ok := instanceLabels[key]; !ok {
 				instanceLabelsChanged = true
-				if err := utils.RemoveWatchForSecret(ctx, r.Client, types.NamespacedName{Name: secretName, Namespace: serviceInstance.Namespace}, string(serviceInstance.UID)); err != nil {
-					log.Error(err, fmt.Sprintf("failed to unwatch secret %s", secretName))
+				if err := utils.RemoveWatchForSecret(ctx, r.Client, types.NamespacedName{Name: value, Namespace: serviceInstance.Namespace}, string(serviceInstance.UID)); err != nil {
+					log.Error(err, fmt.Sprintf("failed to unwatch secret %s", value))
 					return nil, err
 				}
 			}