Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlayerTimeSlider not being draggable #447

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Feb 19, 2024

Pull request

Description

Since Compose Material3 1.2.0 (introduced in #421), the onValueChangeFinished callback is remembered in the SliderState. This prevents the Slider thumb from being dragged. By making the ProgressTrackerState stable, we can work around that, and having the Slider behave as we expect it to.

Changes made

  • Fix the Slider as explained above
  • Fix flaky test in MediaItemTrackerTest and enable full test stacktrace in every module

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 19, 2024

Code Coverage

Overall Project 45.93% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 force-pushed the 445-fix-slider-not-being-draggable branch from 1e61f9b to a4ed16d Compare February 19, 2024 15:44
@StaehliJ StaehliJ added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit 49eed2c Feb 20, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 445-fix-slider-not-being-draggable branch February 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Slider not being draggable
2 participants