Fix PlayerTimeSlider
not being draggable
#447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Since Compose Material3 1.2.0 (introduced in #421), the
onValueChangeFinished
callback is remembered in theSliderState
. This prevents theSlider
thumb from being dragged. By making theProgressTrackerState
stable, we can work around that, and having theSlider
behave as we expect it to.Changes made
Slider
as explained aboveMediaItemTrackerTest
and enable full test stacktrace in every moduleChecklist
main
branch.