Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update monitoring specifications #99

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Update monitoring specifications #99

merged 5 commits into from
Sep 25, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Sep 24, 2024 •
edited
Loading

Description

This PR updates the documentation to most recent specifications, as reported in the linked issue.

Changes Made

  • Add conventions for picking names for keys and constants.
  • Update case where appropriate.
  • Add field to convey number of dropped frames.
  • Fix links to JSON schemas.

@defagos defagos linked an issue Sep 24, 2024 that may be closed by this pull request
Update monitoring specifications #98
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-25 07:51 UTC

@defagos defagos marked this pull request as draft September 24, 2024 12:31
@defagos defagos marked this pull request as ready for review September 24, 2024 12:33
amtins
amtins approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@defagos defagos added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 328ca46 Sep 25, 2024
1 check passed
@defagos defagos deleted the 98-update-monitoring-specifications branch September 25, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 left review comments

@amtins amtins amtins approved these changes

@StaehliJ StaehliJ Awaiting requested review from StaehliJ StaehliJ is a code owner

@jboix jboix Awaiting requested review from jboix jboix is a code owner

@waliid waliid Awaiting requested review from waliid waliid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update monitoring specifications
3 participants
@defagos @MGaetan89 @amtins