Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rule “azure-budgets/rule” #7365

Conversation

AttackOnMorty
Copy link
Member

@AttackOnMorty AttackOnMorty commented Nov 29, 2023

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Problem found by myself

  1. What was changed?

Updated invalid link

  1. Did you do pair or mob programming (and list names)?

No

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old and removed Age: 🥚 - New About 2 hours old labels Nov 29, 2023
@github-actions github-actions bot added Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Nov 29, 2023
@JackDevAU
Copy link
Member

Hey @tiagov8,

This seems to be a false positive. Its picking up an issue with the list of numbered items. But in this case it makes sense.

I'm unsure why it ran and didn't comment though, I'll have a look into that today.

This PR can be merged fine.

@adamcogan
Copy link
Member

adamcogan commented Nov 29, 2023

Hi @JackDevAU
⚠️ I much prefer you fix it first.
I think that's a better approach, so we know it's properly fixed
-a

@@ -127,7 +129,7 @@ ${{ AMOUNT }} AUD + GST/year

1. Please approve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Issue:

1. Please approve

\< As per https://ssw.com.au/rules/azure-budgets \>
:::
:::

3. If the request is approved, remember to add a cost-category tag to the new resource once it is created

The issue is being picked up due to the above ordered list being out of sync. Since it doesn't know that the 1 is part of an email and not a continuation of the 2 further up.

@JackDevAU
Copy link
Member

To fix the issue we can change the ordered list from 1,2,3 etc... to 1. 1. 1.

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old and removed Age: 🐤 - Mature About 16 hours old labels Nov 30, 2023
@JackDevAU
Copy link
Member

Update

As per my conversation with @bradystroud, due to how forked PR's work - we can't currently comment on PR's (like this one). So for now - I will disable the validator for forked branches until we have a workaround as seen in @wicksipedia video on this subject. https://youtu.be/h05ZuwgOa8Q?si=UWqinPh6OKcYlJ7F

@wicksipedia
Copy link
Member

I will disable the validator for forked branches until we have a workaround as seen in @wicksipedia video on this subject. https://youtu.be/h05ZuwgOa8Q?si=UWqinPh6OKcYlJ7F

remember to smash the like and subscribe button

@github-actions github-actions bot added the Age: 🍗 - Ancient About 64 hours old label Nov 30, 2023
@github-actions github-actions bot added 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Nov 30, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Howzit @AttackOnMorty,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@JackDevAU JackDevAU merged commit c1ece2f into SSWConsulting:main Dec 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants