-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rule “azure-budgets/rule” #7365
Update Rule “azure-budgets/rule” #7365
Conversation
Hey @tiagov8, This seems to be a false positive. Its picking up an issue with the list of numbered items. But in this case it makes sense. I'm unsure why it ran and didn't comment though, I'll have a look into that today. This PR can be merged fine. |
Hi @JackDevAU |
@@ -127,7 +129,7 @@ ${{ AMOUNT }} AUD + GST/year | |||
|
|||
1. Please approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Issue:
1. Please approve
\< As per https://ssw.com.au/rules/azure-budgets \>
:::
:::
3. If the request is approved, remember to add a cost-category tag to the new resource once it is created
The issue is being picked up due to the above ordered list being out of sync. Since it doesn't know that the 1 is part of an email and not a continuation of the 2 further up.
To fix the issue we can change the ordered list from 1,2,3 etc... to 1. 1. 1. |
UpdateAs per my conversation with @bradystroud, due to how forked PR's work - we can't currently comment on PR's (like this one). So for now - I will disable the validator for forked branches until we have a workaround as seen in @wicksipedia video on this subject. https://youtu.be/h05ZuwgOa8Q?si=UWqinPh6OKcYlJ7F |
remember to smash the like and subscribe button |
Howzit @AttackOnMorty, This PR has been here a while. Did you know you should avoid merge debt?
Thanks! |
Problem found by myself
Updated invalid link
No