Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ CodeAuditor - Fixed broken link with wrong redirect #7827

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

tombui99
Copy link
Contributor

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Latest CodeAuditor scan on SSW Rules detected this broken Rule (https://www.ssw.com.au/rules/build-a-yes-ladder-to-your-outbound-script) as this rule's title was renamed.

See scan details https://codeauditor.com/htmlhint/00131182-1996-42cc-882e-01850d65a5d6

  1. What was changed?
  • Added redirect for the new Rule's title
  • Renamed the category name to match the new rule.
  1. Did you do pair or mob programming (list names)?

No

@tombui99 tombui99 added the codeauditor fix Fixes from CodeAuditor reports label Jan 24, 2024
@tombui99 tombui99 requested a review from tiagov8 January 24, 2024 03:43
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Jan 24, 2024
Copy link
Contributor

Hi @tombui99,

Rule: ../../rules/build-a-yes-ladder-to-your-outbound-script/rule.md

Issues:

  • 'authors' must be valid content.

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 4
Total 4

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title CodeAuditor - Fixed broken link with wrong redirect XS✔ ◾ CodeAuditor - Fixed broken link with wrong redirect Jan 24, 2024
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Jan 24, 2024
@tiagov8
Copy link
Member

tiagov8 commented Jan 24, 2024

Hey @bradystroud @BrookJeynes @Harry-Ross

I can't resolve the conflicts for this one (button disabled to me)

  • 1. Please investigate and fix

@github-actions github-actions bot added Age: 🐓 - Old About 32 hours old and removed Age: 🐤 - Mature About 16 hours old labels Jan 24, 2024
@sethdaily sethdaily enabled auto-merge (squash) January 25, 2024 00:09
@github-actions github-actions bot added Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🐓 - Old About 32 hours old labels Jan 25, 2024
Copy link
Contributor

Howzit @tombui99,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Jan 26, 2024
@sethdaily sethdaily merged commit 9f0c902 into main Jan 29, 2024
5 checks passed
@sethdaily sethdaily deleted the tom-patch-1 branch January 29, 2024 04:04
@github-actions github-actions bot restored the tom-patch-1 branch January 29, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old codeauditor fix Fixes from CodeAuditor reports 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants