Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XS✔ ◾ Added async checking section to "Checked by" rule #7859

Merged
merged 2 commits into from
Jan 29, 2024
Merged

XS✔ ◾ Added async checking section to "Checked by" rule #7859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
733e669
Added async checking section
tiagov8 Jan 29, 2024
0dfb661
Auto-fix Markdown files
github-actions[bot] Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions rules/checked-by-xxx/rule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Scenarios where having someone review your emails is recommended:
* You are a little unsure
* You feel that it is a complicated email
* Sending a sensitive email (e.g. The content could be perceived as confrontational)
* You need a quick '[test please](/conduct-a-test-please)', and the person is immediately available. This provides you a chance to check and collaborate on the finished change before the '[done email](/dones-do-you-reply-done-and-delete-the-original-email)' is sent. It also shows the email was double-checked.
* You need a quick '[test please](/conduct-a-test-please)', and the person is immediately available. This provides you a chance to check and collaborate on the finished change before the '[done email](/dones-do-you-reply-done-and-delete-the-original-email)' is sent. It also shows the email was double-checked

Doing this will ensure:

Expand Down Expand Up @@ -71,6 +71,13 @@ Dave
Figure: Good example - Use 'Checked by xxx' when sending emails that require a second pair of eyes
:::

### Async checking

By “checked by”, people will assume there was a conversation. When that was not possible and the case, it is OK to do it async (via chatting on Teams or Email) as long as it is specified in your email. Examples:

* (Checked **via Teams Chat** by Chris S and Lloyd)
* (Checked **via Email** by Chris S and Lloyd)

### Avoid being blocked

Waiting for the 'checked by' may slow down your email to be sent... a proactive approach is to ping a couple of people with a message. E.g. *"I would like a Test Please, if you have time today call me back because I will be hitting send by 4pm today"*
Expand All @@ -87,6 +94,6 @@ Once you confirm there are no errors, you may add the content to the site.

After that, run [SSW CodeAuditor](https://codeauditor.com) in order to keep 0 broken links and other web errors on that page.

### Still not convinced?
### Still not convinced?

If you need more convincing of the efficacy of this rule, [listen to this song](https://app.suno.ai/song/ebd75192-9787-4c94-b0b2-b48f1bd313bb/) 😀
If you need more convincing of the efficacy of this rule, [listen to this song](https://app.suno.ai/song/ebd75192-9787-4c94-b0b2-b48f1bd313bb/) 😀