-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XS✔ ◾ Made "include URL" rule generic... instead of just for "Dones" #8278
Conversation
PR Metrics✔ Thanks for keeping your pull request small.
Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs! |
Hi @tiagov8, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
Howzit @tiagov8, This PR has been here a while. Did you know you should avoid merge debt?
Thanks! |
related: [] | ||
related: | ||
- add-context-reasoning-to-emails | ||
- dones-do-you-include-useful-details-in-your-done-email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rule actually a duplicate of dones-do-you-include-useful-details-in-your-done-email ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see as:
-
https://ssw.com.au/rules/add-context-reasoning-to-emails/
Add context when you send an email -
https://ssw.com.au/rules/dones-do-you-include-useful-details-in-your-done-email/
Add any useful info, such as context, screenshots, code changes etc... to "Done" emails -
https://ssw.com.au/rules/dones-do-your-dones-include-a-url/
Add URLs (links) to any emailI think the 3 rules can live together... they are out there for a while... but if you disagree... I would recommend getting this PR through and opening a new Issue to look into merging them.
-
1. Please resolve conversation and approve the changes if you agree
Co-authored-by: Jayden Alchin [SSW] <[email protected]>
Hi @tiagov8, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
Hi @tiagov8, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
Hi @tiagov8, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
Hi @tiagov8, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
FYI - I updated the URI for this rule after you previous review/comments |
Hi @tiagov8, We found some markdown suggestions for your Pull Request:
Please review and update your Markdown files accordingly. |
cc @adamcogan @BenDunkerleySSW
Re: Formatting changes to SugarLearning item
Made "include URL" rule generic... instead of just for "Dones"
no