Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Made "include URL" rule generic... instead of just for "Dones" #8278

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

tiagov8
Copy link
Member

@tiagov8 tiagov8 commented Mar 28, 2024

cc @adamcogan @BenDunkerleySSW

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

Re: Formatting changes to SugarLearning item

  1. What was changed?

Made "include URL" rule generic... instead of just for "Dones"

  1. Did you do pair or mob programming (list names)?

no

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Mar 28, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 12
Total 12

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Made "include URL" rule generic... instead of just for "Dones" XS✔ ◾ Made "include URL" rule generic... instead of just for "Dones" Mar 28, 2024
Copy link
Contributor

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/dones-do-your-dones-include-a-url/rule.md Line 59 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Mar 28, 2024
Copy link
Contributor

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

@github-actions github-actions bot added Age: 🦖 - Extinct About 128 hours old and removed Age: 🍗 - Ancient About 64 hours old labels Mar 31, 2024
rules/dones-do-your-dones-include-a-url/rule.md Outdated Show resolved Hide resolved
related: []
related:
- add-context-reasoning-to-emails
- dones-do-you-include-useful-details-in-your-done-email
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this rule actually a duplicate of dones-do-you-include-useful-details-in-your-done-email ?

Copy link
Member Author

@tiagov8 tiagov8 Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jaydenalchin

I see as:

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/dones-do-your-dones-include-a-url/rule.md Line 59 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 44: column count Rule MD056
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 61: column count Rule MD056
rules/dones-do-your-dones-include-a-url/rule.md Line 60 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 44: column count Rule MD056
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 61: column count Rule MD056
rules/dones-do-your-dones-include-a-url/rule.md Line 60 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/add-context-reasoning-to-emails/rule.md Line 35: column count Rule MD056
rules/add-context-reasoning-to-emails/rule.md Line 52: column count Rule MD056
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 44: column count Rule MD056
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 61: column count Rule MD056
rules/dones-do-your-dones-include-a-url/rule.md Line 60 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

@tiagov8
Copy link
Member Author

tiagov8 commented Apr 4, 2024

Hi @jaydenalchin

FYI - I updated the URI for this rule after you previous review/comments

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi @tiagov8,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/add-context-reasoning-to-emails/rule.md Line 35: column count Rule MD056
rules/add-context-reasoning-to-emails/rule.md Line 52: column count Rule MD056
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 44: column count Rule MD056
rules/dones-do-you-include-useful-details-in-your-done-email/rule.md Line 61: column count Rule MD056
rules/dones-do-your-dones-include-a-url/rule.md Line 60 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: levels should only increment by one level at a time Rule MD001

Please review and update your Markdown files accordingly.

@jaydenalchin jaydenalchin merged commit 5712f4e into main Apr 5, 2024
4 of 5 checks passed
@jaydenalchin jaydenalchin deleted the tiagov8-patch-8 branch April 5, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🦖 - Extinct About 128 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants