Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on the rules I created recently #8305

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Fix typo on the rules I created recently #8305

merged 4 commits into from
Apr 5, 2024

Conversation

JimmyChenSSW
Copy link
Contributor

Tip: Use SSW Rule Writer GPT for help with writing rules 🤖

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

I go through the recently rules created by me with Stephan and get some small typo that need to be fixed

  1. What was changed?

Small typo issues, spelling and little formatting.

  1. Did you do pair or mob programming (list names)?

Yes, with @stephanfakossw

@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Apr 5, 2024
@tiagov8
Update rule.md
777ebd4
@tiagov8
Update rule.md
47b6c5f 
Hi @JimmyChenSSW 

I've made some improvements to your rule ;)
tiagov8
tiagov8 reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JimmyChenSSW

FYI "E.g." without the comma is fine, so I removed it.

I also made improvements to both your rules... please see my changes in the PR if you want to learn more

@tiagov8 tiagov8 merged commit 9d60c8c into SSWConsulting:main Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagov8 tiagov8 tiagov8 approved these changes

@tombui99 tombui99 Awaiting requested review from tombui99

@stephanfakossw stephanfakossw Awaiting requested review from stephanfakossw

Assignees
No one assigned
Labels
Age: 🐤 - Mature About 16 hours old
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimmyChenSSW @tiagov8