Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Weekly client love - improving content and shorten URI's #8417

Merged
merged 11 commits into from
Apr 22, 2024

Conversation

bradystroud
Copy link
Member

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

email "Rules - client love"

  1. What was changed?

✏️

  1. Did you do pair or mob programming (list names)?

Worked with @tkapa
✏️

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Apr 22, 2024
Copy link
Contributor

github-actions bot commented Apr 22, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 145
Total 145

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Weekly client love - improving content and shorten URI's XS✔ ◾ Weekly client love - improving content and shorten URI's Apr 22, 2024
Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/weekly-client-love/rule.md Line 48: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/client-love-after-initial-meeting/rule.md Line 44: list item prefix Rule MD029
rules/client-love-after-initial-meeting/rule.md Line 48: list item prefix Rule MD029
rules/weekly-client-love/rule.md Line 48: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/client-love-after-initial-meeting/rule.md Line 44: list item prefix Rule MD029
rules/client-love-after-initial-meeting/rule.md Line 48: list item prefix Rule MD029
rules/weekly-client-love/rule.md Line 48: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/client-love-after-initial-meeting/rule.md Line 44: list item prefix Rule MD029
rules/client-love-after-initial-meeting/rule.md Line 48: list item prefix Rule MD029
rules/weekly-client-love/rule.md Line 25: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

@tiagov8 tiagov8 requested a review from uly1 April 22, 2024 17:15
Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/client-love-after-initial-meeting/rule.md Line 44: list item prefix Rule MD029
rules/client-love-after-initial-meeting/rule.md Line 48: list item prefix Rule MD029
rules/weekly-client-love/rule.md Line 25: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

@tiagov8
Copy link
Member

tiagov8 commented Apr 22, 2024

Hi @bradystroud

I've added many more changes to your PR, so I'm leaving it for someone else to review ;)

Copy link
Contributor

Hi @bradystroud,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/client-love-after-initial-meeting/rule.md Line 46: list item prefix Rule MD029
rules/client-love-after-initial-meeting/rule.md Line 50: list item prefix Rule MD029
rules/weekly-client-love/rule.md Line 27: should have alternate text (alt text) Rule MD045

Please review and update your Markdown files accordingly.

@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old labels Apr 22, 2024
@uly1 uly1 merged commit 9124e99 into main Apr 22, 2024
4 of 5 checks passed
@uly1 uly1 deleted the weekly-client-love branch April 22, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐥 - Adolescent About 8 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants