-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new rule best Framework Rule #9478
add new rule best Framework Rule #9478
Conversation
rules/do-you-know-the-best-framework-to-build-an-admin-interface/rule.md
Outdated
Show resolved
Hide resolved
rules/do-you-know-the-best-framework-to-build-an-admin-interface/rule.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test pass with suggestions
…ce/rule.md Co-authored-by: Matt Wicks [SSW] <[email protected]>
…ce/rule.md Co-authored-by: Matt Wicks [SSW] <[email protected]>
Hi @tomek-i I've made some content design changes to your new rule. And I noticed it's missing belonging to a category... so I added a task in my review PS. There is another unrelated change in this PR (on the email placeholders UPPERCASING). This part looks fine, but it seems like the same as this other PR #9473 . Unclear how this happened, but check so it can be avoided next time ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 1. Please add to category
Yes, I did see that too. The first change i made with the UI and then wrote a new rule but that resulted in the UI to throw errors and people suggested to do it via github. I think it branched off from that other PR that why it included both changes. Will fix the category and figure out the validation error sometime today. Thanks |
✏️ Missing rule
✏️This pull request adds the addition of a new rule.
The new rule provides information on the best frameworks to build an Admin Interface for web applications, including React/Next.js, Blazor, and Angular. These updates and additions aim to improve the functionality and usability of the application.
✏️ Solo