Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new rule best Framework Rule #9478

Conversation

tomek-i
Copy link
Member

@tomek-i tomek-i commented Oct 24, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ Missing rule

  1. What was changed?

✏️This pull request adds the addition of a new rule.
The new rule provides information on the best frameworks to build an Admin Interface for web applications, including React/Next.js, Blazor, and Angular. These updates and additions aim to improve the functionality and usability of the application.

  1. Did you do pair or mob programming (list names)?

✏️ Solo

Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test pass with suggestions

@github-actions github-actions bot added Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old labels Oct 24, 2024
@tiagov8
Copy link
Member

tiagov8 commented Oct 24, 2024

Hi @tomek-i

I've made some content design changes to your new rule.

And I noticed it's missing belonging to a category... so I added a task in my review

PS. There is another unrelated change in this PR (on the email placeholders UPPERCASING). This part looks fine, but it seems like the same as this other PR #9473 . Unclear how this happened, but check so it can be avoided next time ;)

Copy link
Member

@tiagov8 tiagov8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1. Please add to category

@tomek-i
Copy link
Member Author

tomek-i commented Oct 24, 2024

Hi @tomek-i

I've made some content design changes to your new rule.

And I noticed it's missing belonging to a category... so I added a task in my review

PS. There is another unrelated change in this PR (on the email placeholders UPPERCASING). This part looks fine, but it seems like the same as this other PR #9473 . Unclear how this happened, but check so it can be avoided next time ;)

Yes, I did see that too. The first change i made with the UI and then wrote a new rule but that resulted in the UI to throw errors and people suggested to do it via github. I think it branched off from that other PR that why it included both changes.

Will fix the category and figure out the validation error sometime today. Thanks

@tiagov8 tiagov8 merged commit 488b655 into SSWConsulting:main Oct 24, 2024
5 checks passed
@tomek-i tomek-i deleted the cms/tomek-i/SSW.Rules.Content/rule/best-framework/rule branch October 25, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🐤 - Mature About 16 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants