Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗑️ Deleted profiles page #1585

Merged
merged 9 commits into from
Oct 24, 2024
Merged

🗑️ Deleted profiles page #1585

merged 9 commits into from
Oct 24, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Oct 21, 2024 •
edited
Loading

Relates to #1567

Summary video of the discussion: https://youtu.be/J2Hx9rGU0cM
Email subject: SSW.Rules - Reactions feature broken

As per decision to integrate Giscus, we can't no longer get specific user reactions for Profiles page.
So in this PR I did these changes:

  • Deleted Profiles page
  • Deleted any component is used in Profiles page
  • Deleted comments-no-connected component, because it is unused
  • Cleaned up styles related Profiles page
  • Cleaned up Azure Functions that no longer are used in apiService.js

@babakamyljanovssw babakamyljanovssw mentioned this pull request Oct 22, 2024
Closed
8 tasks
@babakamyljanovssw babakamyljanovssw marked this pull request as ready for review October 23, 2024 09:46
@babakamyljanovssw babakamyljanovssw changed the title Delete profile page 🗑️ Deleted profiles page Oct 23, 2024
bradystroud
bradystroud requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is also some stuff to delete on the rules page (where we fetch the reactions)

src/services/apiService.js Outdated Show resolved Hide resolved
@babakamyljanovssw babakamyljanovssw self-assigned this Oct 24, 2024
bradystroud
bradystroud approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babakamyljanovssw babakamyljanovssw merged commit 8f43c4d into main Oct 24, 2024
5 checks passed
@babakamyljanovssw babakamyljanovssw deleted the delete-profile branch October 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradystroud bradystroud bradystroud approved these changes

@JackDevAU JackDevAU Awaiting requested review from JackDevAU

Assignees

@babakamyljanovssw babakamyljanovssw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babakamyljanovssw @bradystroud