-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Reactions - Migrate from custom to Giscus #1567
Comments
Update: Giscus reactions can't be separately implemented, because out of box it only supports to disable reactions not discussions. About migrating data:Custom Reactions Disqus Comments I found a repo that migrates comments from Disqus to Giscus, this tool adds old comments to Giscus discussion, and links the comment to one specified user. For example we can create account with name comment-migrator and the old message will be added in below format:
So here the original author name will be displayed in the comment and commented account will be comment-migrator. Repo - Disqus to GitHub issues - https://github.com/JuergenGutsch/disqus-to-github-issues/tree/master/DisqusToGithubIssues As per this comment #1382 (comment) from old PR that adds Giscus, Adam suggested we have Giscus and Disqus for now. |
PR - Add Giscus - #1579 Note
|
You are ready to Giscus to prod! As per our conversation, there are 2 things to check with Adam first.
|
Update: Created PR on SSW.Rules.Functions to remove |
Hey @bradystroud
I did looked at Giscus repo source code and documentation, and if we are going to introduce new prop to widget such as
Currently, I don't see any other good option than GUID to link existing discussions to rule. Also, creating rule discussion in the General category with rule GUID as title is not big problem because people usually go to rules website to see comments not to the repo. For Chewing the Fat, we are changing the category and title when we do it, so all Chewing the Fat discussion will be looked nice and easy to find. |
As per our conversation, Please record a Done Video @babakamyljanovssw 🙏
|
cc: @bradystroud @JackDevAU @Calinator444
✅ Done - please see it here https://youtu.be/sX5wvR_RLqA |
✅ @bradystroud has updated the template - Microsoft Forms Chewing the fat template |
✅ All tasks done - closing issue |
Cc: @adamcogan @wicksipedia @bradystroud @tkapa
Hi Team,
Summary video of the discussion: https://youtu.be/J2Hx9rGU0cM
Email subject: SSW.Rules - Reactions feature broken
As per our conversation on Teams calls, it was decided that we are going to use Giscus for Reactions instead of Azure Functions.
Tasks
Done Video - https://youtu.be/J2Hx9rGU0cM
The text was updated successfully, but these errors were encountered: