Remove 'production entities enabled' feature toggle from the Service entity #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/remove-prod-ent-enabled-switch
branch
2 times, most recently
from
2e778b3
to
4472496
Compare
From the Service entity. This setting is never used. All services have the production enitties enabled by default. So this setting is never used, and can be removed
MKodde
force-pushed
the
feature/remove-prod-ent-enabled-switch
branch
from
4472496
to
d24e12c
Compare
parijke
approved these changes
May 16, 2024
| @@ -51,7 +50,7 @@ public function __construct( | |||
| private ?string $intakeStatus, | |||
| private ?string $contractSigned, | |||
| private ?string $surfconextRepresentativeApproved, | |||
| private ?string $privacyQuestionsAnswered, | |||
| private bool $privacyQuestionsAnswered, | |||
There was a problem hiding this comment.
not nullable anymore?
BTW, I heard a statement, that bool variables "sh|c"ould be named with is in front, like $isPrivacyQuestionAnswered.
Butt hat is probably not for now
There was a problem hiding this comment.
If is is not nullebale, maybe initilize it with false to be sure?
There was a problem hiding this comment.
Good point, I looked it up, and it should always be set. My own testing and the CI functional tests did confirm my assumption. I feel confident to leave it like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'production entities enabled' feature toggle is not used by the PO's of SPD. They always allow the services to create production entites. Having this featue is illogical, and it can be cleaned up.
Note that a Doctrine migration was created to remove the column from the
servicetable.https://www.pivotaltracker.com/story/show/187053888