Remove filter column and add the extra explanation text #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MKodde
commented
Jun 18, 2024
•
MKodde
commented
- The filter column is removed from the template as it is out of scope for now.
- An additional translatable explanation text was added
- Webtests have been reinstated
MKodde
force-pushed
the
feature/surfconext-verantwoordelijke-remove-filter
branch
2 times, most recently
from
89bee6d
to
a5f9409
Compare
parijke
requested changes
Jun 18, 2024
| @@ -49,6 +49,12 @@ public function shouldFailCreateIssue(): void | |||
| $this->failIssueCreation = true; | |||
| $this->storeData(); | |||
| } | |||
| public function shouldNotFailCreateIssue(): void | |||
There was a problem hiding this comment.
This is a weird method name. No method should ever fail, but they do... not clear to me
There was a problem hiding this comment.
Haha it is weird indeed, this a method that modifies the behavior of a fixture. You can enable it to simulate Jira being down. I think it precisely describes its (test) purpose. And I'd like to keep it as it is.
There was a problem hiding this comment.
Why not call it enableJiraDownSimulation() then?
There was a problem hiding this comment.
I find this more fitting in functional tests, but my pardigm is mainly gherkin oriented. I feel this fits the bill good'nuf
MKodde
force-pushed
the
feature/surfconext-verantwoordelijke-authz
branch
2 times, most recently
from
8c12aae
to
e66a0ff
Compare
Base automatically changed from
feature/surfconext-verantwoordelijke-authz
to
main
June 19, 2024 06:48
It will not be included on the MVP of the surfconext representative page. No need to include it, leaving extra space for the SP/IdP entities.
And adjust other webtests to the new Fixtures created for the surfconext representative page
MKodde
force-pushed
the
feature/surfconext-verantwoordelijke-remove-filter
branch
from
a5f9409
to
928e35b
Compare
parijke
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.