Fix Baynes Sound AGRIF figure #326
Merged
+510
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the bathymetry URL reference in the Baynes Sound AGRIF figure configuration with a local grid path because the V17-02 bathymetry dataset has been removed from the ERDDAP server. Adjusted related test cases and updated the figure development and testing notebooks to align with the new configuration.
The change ensures consistent use of the h5netcdf engine when opening datasets with xarray. This improves compatibility and aligns with recommended practices for handling NetCDF files in the workflow.
douglatornell
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 77.72% 77.72% -0.01%
==========================================
Files 132 132
Lines 18777 18780 +3
Branches 762 762
==========================================
+ Hits 14595 14597 +2
- Misses 4116 4117 +1
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Previously, the contour level calculation used non-scalar types directly, causing errors. Added `.values` to ensure proper handling of scalar values extracted from xarray objects. This issue arose with the change to `numpy>=2`.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production figure generation started failing due to 11-Jan-2025 due to removal of
ubcSSnBathymetryV17-02dataset from ERDDAP. Refactoring to address that change revealed opportunities for modernization of the figure module, and an issue arising from the change tonumpy>=2that was also addressed.