Skip to content

fix: fixed the bug that method CurrentTaskFinished was executed multiple times by multiple threads #1343

fix: fixed the bug that method CurrentTaskFinished was executed multiple times by multiple threads

fix: fixed the bug that method CurrentTaskFinished was executed multiple times by multiple threads #1343

Triggered via pull request September 8, 2024 06:14
Status Success
Total duration 5m 29s
Artifacts 4

build.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

44 warnings
build (Release, x64)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3, microsoft/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (Release, x64): src/Starward.Launcher/Starward.Launcher.cpp#L23
'argument': conversion from 'size_t' to 'DWORD', possible loss of data
build (Release, x64): src/Starward.Launcher/Starward.Launcher.cpp#L24
'argument': conversion from 'size_t' to 'DWORD', possible loss of data
build (Release, x64): src/Starward.Core/HoYoPlay/HoYoPlayClient.cs#L56
Using member 'System.Text.Json.JsonSerializer.Deserialize<TValue>(JsonNode, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
build (Release, x64): src/Starward/Controls/InstallGameDialog.xaml.cs#L290
The variable 'ex' is declared but never used
build (Release, x64): src/Starward/Controls/GameBizSelector.xaml.cs#L143
The variable 'ex' is declared but never used
build (Release, x64): src/Starward/Controls/GameBannerAndPost.xaml.cs#L236
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, x64): src/Starward/Controls/ColorfulTextBlock.xaml.cs#L117
The variable 'ex' is declared but never used
build (Release, x64): src/Starward/Pages/Welcome/SelectGamePage.xaml.cs#L110
'AppConfig.SetLastRegionOfGame(GameBiz, GameBiz)' is obsolete: '已不用'
build (Release, x64): src/Starward/Services/Gacha/ZZZGachaService.cs#L222
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, x64): src/Starward/Services/Gacha/ZZZGachaService.cs#L241
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, arm64)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3, microsoft/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (Debug, arm64): src/Starward.Core/HoYoPlay/HoYoPlayClient.cs#L56
Using member 'System.Text.Json.JsonSerializer.Deserialize<TValue>(JsonNode, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
build (Debug, arm64): src/Starward/Controls/InstallGameDialog.xaml.cs#L290
The variable 'ex' is declared but never used
build (Debug, arm64): src/Starward/Pages/Welcome/SelectGamePage.xaml.cs#L110
'AppConfig.SetLastRegionOfGame(GameBiz, GameBiz)' is obsolete: '已不用'
build (Debug, arm64): src/Starward/Services/Gacha/ZZZGachaService.cs#L222
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, arm64): src/Starward/Services/Gacha/ZZZGachaService.cs#L241
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, arm64): src/Starward/Controls/GameBizSelector.xaml.cs#L143
The variable 'ex' is declared but never used
build (Debug, arm64): src/Starward/Controls/GameBannerAndPost.xaml.cs#L236
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, arm64): src/Starward/Pages/GameLauncherPage.xaml.cs#L1668
The variable 'ex' is declared but never used
build (Debug, arm64): src/Starward/Pages/GameLauncherPage.xaml.cs#L1662
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, arm64): src/Starward/Controls/ColorfulTextBlock.xaml.cs#L117
The variable 'ex' is declared but never used
build (Debug, x64)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3, microsoft/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (Debug, x64): src/Starward.Launcher/Starward.Launcher.cpp#L23
'argument': conversion from 'size_t' to 'DWORD', possible loss of data
build (Debug, x64): src/Starward.Launcher/Starward.Launcher.cpp#L24
'argument': conversion from 'size_t' to 'DWORD', possible loss of data
build (Debug, x64): src/Starward.Core/HoYoPlay/HoYoPlayClient.cs#L56
Using member 'System.Text.Json.JsonSerializer.Deserialize<TValue>(JsonNode, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
build (Debug, x64): src/Starward/Controls/InstallGameDialog.xaml.cs#L290
The variable 'ex' is declared but never used
build (Debug, x64): src/Starward/Controls/GameBizSelector.xaml.cs#L143
The variable 'ex' is declared but never used
build (Debug, x64): src/Starward/Controls/ColorfulTextBlock.xaml.cs#L117
The variable 'ex' is declared but never used
build (Debug, x64): src/Starward/Pages/Welcome/SelectGamePage.xaml.cs#L110
'AppConfig.SetLastRegionOfGame(GameBiz, GameBiz)' is obsolete: '已不用'
build (Debug, x64): src/Starward/Controls/GameBannerAndPost.xaml.cs#L236
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, x64): src/Starward/Services/Gacha/ZZZGachaService.cs#L222
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Debug, x64): src/Starward/Services/Gacha/ZZZGachaService.cs#L241
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, arm64)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3, microsoft/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (Release, arm64): src/Starward.Core/HoYoPlay/HoYoPlayClient.cs#L56
Using member 'System.Text.Json.JsonSerializer.Deserialize<TValue>(JsonNode, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved.
build (Release, arm64): src/Starward/Controls/InstallGameDialog.xaml.cs#L290
The variable 'ex' is declared but never used
build (Release, arm64): src/Starward/Controls/GameBizSelector.xaml.cs#L143
The variable 'ex' is declared but never used
build (Release, arm64): src/Starward/Controls/GameBannerAndPost.xaml.cs#L236
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, arm64): src/Starward/Controls/ColorfulTextBlock.xaml.cs#L117
The variable 'ex' is declared but never used
build (Release, arm64): src/Starward/Pages/Welcome/SelectGamePage.xaml.cs#L110
'AppConfig.SetLastRegionOfGame(GameBiz, GameBiz)' is obsolete: '已不用'
build (Release, arm64): src/Starward/Services/Gacha/ZZZGachaService.cs#L222
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, arm64): src/Starward/Services/Gacha/ZZZGachaService.cs#L241
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, arm64): src/Starward/Pages/GameLauncherPage.xaml.cs#L1668
The variable 'ex' is declared but never used
build (Release, arm64): src/Starward/Pages/GameLauncherPage.xaml.cs#L1662
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Artifacts

Produced during runtime
Name Size
Starward_Debug_arm64_1049448
60.6 MB
Starward_Debug_x64_1049448
62.3 MB
Starward_Release_arm64_1049448
71.8 MB
Starward_Release_x64_1049448
74.4 MB