-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for shamir recovery invitation #8819
Conversation
2c19d47
to
c63b236
Compare
Missing tests for:
|
3dcdb16
to
35ea62b
Compare
Missing multiple news fragments for the CLI change |
You mean for #8429 or for other shamir related commands? I don't think it's worth adding newsfragments for the different shamir commands, a single newsfragment commenting the general feature at the end is enough IMO. |
You would expect at least 2 newsfragment: one for the updated example in the CLI help message, and the other that could group the change related to the added/updated shamir command |
Does that really deserve a newsfragment though? I'd say no, but I can add it if necessary.
This will come later once the feature is fully implemented. |
libparsec/crates/protocol/schema/invited_cmds/invite_info.json5
Outdated
Show resolved
Hide resolved
db4f94d
to
1d426b0
Compare
b16ce69
to
5c1178b
Compare
…ed template with it
5c1178b
to
7f6f885
Compare
7f6f885
to
f3ebc80
Compare
Part of #6090
Close #7359
Fix #8429
Tested with: