Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shamir recovery invitation #8819

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Add support for shamir recovery invitation #8819

merged 20 commits into from
Nov 22, 2024

Conversation

vxgmichel
Copy link
Contributor

@vxgmichel vxgmichel commented Oct 30, 2024

Part of #6090

Close #7359

Fix #8429

Tested with:

$ . ./cli/run_testenv.sh 
[...]
Alice & Bob devices (password: P@ssw0rd.):
- 624 // Alice
- 196 // Alice 2nd device
- 1f2 // Bob

$ echo P@ssw0rd. | target/debug/parsec-cli shared-recovery create --password-stdin -d 1f2
Shamir setup has been created

$ echo P@ssw0rd. | target/debug/parsec-cli invite shared-recovery --password-stdin -d 624 --email [email protected]
Invitation URL: parsec3://127.0.0.1:41997/Org?no_ssl=true&a=claim_shamir_recovery&p=xBCqEy9RIO8HPyycmlus9Qzg

$ echo P@ssw0rd. | target/debug/parsec-cli invite list --password-stdin -d 624
aa132f5120ef073f2c9c9a5bacf50ce0        idle    shamir recovery (Bob <[email protected]>)

$ echo P@ssw0rd. | target/debug/parsec-cli invite cancel --password-stdin -d 624 --token aa132f5120ef073f2c9c9a5bacf50ce0
Invitation deleted

$ echo P@ssw0rd. | target/debug/parsec-cli invite list --password-stdin -d 624 
aa132f5120ef073f2c9c9a5bacf50ce0        cancelled       shamir recovery (Bob <[email protected]>)

@vxgmichel vxgmichel requested review from a team as code owners October 30, 2024 10:51
@vxgmichel vxgmichel marked this pull request as draft October 30, 2024 10:51
@vxgmichel vxgmichel force-pushed the issue-7359 branch 10 times, most recently from 2c19d47 to c63b236 Compare November 1, 2024 16:12
@vxgmichel vxgmichel marked this pull request as ready for review November 1, 2024 16:12
@vxgmichel vxgmichel requested review from a team as code owners November 1, 2024 16:12
@vxgmichel
Copy link
Contributor Author

vxgmichel commented Nov 1, 2024

Missing tests for:

  • invite_list with shamir recovery
  • invite_info for shamir recovery

@vxgmichel vxgmichel force-pushed the issue-7359 branch 2 times, most recently from 3dcdb16 to 35ea62b Compare November 1, 2024 17:10
cli/src/commands/invite/greet.rs Outdated Show resolved Hide resolved
cli/src/commands/invite/claim.rs Show resolved Hide resolved
cli/src/commands/invite/shared_recovery.rs Outdated Show resolved Hide resolved
cli/src/commands/invite/shared_recovery.rs Outdated Show resolved Hide resolved
cli/src/commands/invite/shared_recovery.rs Show resolved Hide resolved
@FirelightFlagboy FirelightFlagboy linked an issue Nov 4, 2024 that may be closed by this pull request
@FirelightFlagboy
Copy link
Contributor

FirelightFlagboy commented Nov 4, 2024

Missing multiple news fragments for the CLI change

@vxgmichel
Copy link
Contributor Author

vxgmichel commented Nov 4, 2024

@FirelightFlagboy

Missing multiple news fragments for the CLI change

You mean for #8429 or for other shamir related commands?

I don't think it's worth adding newsfragments for the different shamir commands, a single newsfragment commenting the general feature at the end is enough IMO.

@FirelightFlagboy
Copy link
Contributor

You would expect at least 2 newsfragment: one for the updated example in the CLI help message, and the other that could group the change related to the added/updated shamir command

@vxgmichel
Copy link
Contributor Author

vxgmichel commented Nov 4, 2024

one for the updated example in the CLI help message,

Does that really deserve a newsfragment though? I'd say no, but I can add it if necessary.

and the other that could group the change related to the added/updated shamir command

This will come later once the feature is fully implemented.

cli/src/commands/invite/greet.rs Outdated Show resolved Hide resolved
cli/src/commands/invite/greet.rs Outdated Show resolved Hide resolved
cli/src/commands/invite/shared_recovery.rs Show resolved Hide resolved
libparsec/crates/client/src/invite/claimer.rs Outdated Show resolved Hide resolved
libparsec/crates/types/tests/unit/addr.rs Show resolved Hide resolved
@vxgmichel vxgmichel enabled auto-merge November 22, 2024 14:58
@vxgmichel vxgmichel added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit d965f3d Nov 22, 2024
16 checks passed
@vxgmichel vxgmichel deleted the issue-7359 branch November 22, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants