Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shamir recovery invitation #8819

Merged
merged 20 commits into from
Nov 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address @FirelightFlagboy's comments
vxgmichel committed Nov 22, 2024
commit aa80ed3bf47d4b25f9dad12156356d675c7bb595
3 changes: 2 additions & 1 deletion cli/src/commands/invite/greet.rs
Original file line number Diff line number Diff line change
@@ -62,7 +62,8 @@ pub async fn main(args: Args) -> anyhow::Result<()> {
step5_device(ctx).await
}
InviteListItem::ShamirRecovery { .. } => {
todo!();
// See: https://github.com/Scille/parsec-cloud/issues/8841
vxgmichel marked this conversation as resolved.
Show resolved Hide resolved
todo!("Implement shamir recovery greeting");
vxgmichel marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
4 changes: 2 additions & 2 deletions cli/src/commands/invite/shared_recovery.rs
Original file line number Diff line number Diff line change
@@ -8,10 +8,10 @@ crate::clap_parser_with_shared_opts_builder!(
#[with = config_dir, device, password_stdin]
pub struct Args {
/// Claimer email (i.e.: The invitee)
#[arg(short, long)]
#[arg(long)]
email: String,
/// Send email to the invitee
#[arg(short, long, default_value_t)]
#[arg(long, default_value_t)]
send_email: bool,
}
);
5 changes: 4 additions & 1 deletion libparsec/crates/client/src/invite/claimer.rs
Original file line number Diff line number Diff line change
@@ -261,7 +261,10 @@ pub async fn claimer_retrieve_info(
UserOrDevice::ShamirRecovery {
recipients,
threshold,
} => todo!("Implement UserOrDeviceClaimInitialCtx::Shamir {recipients:?} {threshold}"),
} => {
// See https://github.com/Scille/parsec-cloud/issues/8841
vxgmichel marked this conversation as resolved.
Show resolved Hide resolved
todo!("Implement UserOrDeviceClaimInitialCtx::Shamir {recipients:?} {threshold}")
}
},
bad_rep @ Rep::UnknownStatus { .. } => {
Err(anyhow::anyhow!("Unexpected server response: {:?}", bad_rep).into())