Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution summary report fixes #1680 #1687

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

MohamedHazem95
Copy link
Contributor

@MohamedHazem95 MohamedHazem95 commented Aug 12, 2024

Fix validations section in Execution summary report to show correct number of validations instead of zeroes
Screen Shot 2024-08-12 at 5 24 51 AM
Screen Shot 2024-08-12 at 5 10 27 AM
New Reports.zip

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.48%. Comparing base (fd84020) to head (f475b44).

Files Patch % Lines
.../shaft/validation/internal/ValidationsHelper2.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1687      +/-   ##
============================================
- Coverage     53.54%   50.48%   -3.07%     
+ Complexity     1283     1233      -50     
============================================
  Files           111      111              
  Lines          9945     9948       +3     
  Branches        959      959              
============================================
- Hits           5325     5022     -303     
- Misses         4020     4348     +328     
+ Partials        600      578      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MohabMohie MohabMohie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your valued contribution!

@MohabMohie MohabMohie merged commit aded005 into ShaftHQ:main Aug 12, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants