Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution summary report fixes #1680 #1687

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Execution summary report fixes #1680 #1687

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd09227
-Fix Validations section in Execution summary report
MohamedHazem95 Aug 12, 2024
f475b44
Merge branch 'main' into executionSummaryReportFix
MohamedHazem95 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/shaft/validation/internal/ValidationsHelper2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,15 +263,18 @@
if (!validationState) {
String failureMessage = this.validationCategoryString.replace("erify", "erificat") + "ion failed; expected " + expected + ", but found " + actual;
if (this.validationCategory.equals(ValidationEnums.ValidationCategory.HARD_ASSERT)) {
ReportManagerHelper.logNestedSteps(failureMessage, null ,null);
Allure.getLifecycle().updateStep(stepResult -> FailureReporter.fail(failureMessage));
} else {
// soft assert
ValidationsHelper.verificationFailuresList.add(failureMessage);
ValidationsHelper.verificationError = new AssertionError(String.join("\nAND ", ValidationsHelper.verificationFailuresList));
Allure.getLifecycle().updateStep(stepResult -> ReportManager.log(failureMessage));
ReportManagerHelper.logNestedSteps(failureMessage, null ,null);

Check warning on line 273 in src/main/java/com/shaft/validation/internal/ValidationsHelper2.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/shaft/validation/internal/ValidationsHelper2.java#L273 

Added line #L273 was not covered by tests
}
} else {
Allure.getLifecycle().updateStep(stepResult -> ReportManager.log(this.validationCategoryString.replace("erify", "erificat") + "ion passed"));
ReportManagerHelper.logNestedSteps(validationCategoryString.replace("erify", "erificat") + "ion passed" , null ,null);
}
}
}
Loading