Fix: Ensure Content-Type is set based on header value if not explicitly set #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 17, 2024 19:42
…ly set - Modified the `prepareRequestSpecs` method to check if `contentType` is still `ContentType.ANY`. - If `ContentType` is not explicitly set by the user, it now retrieves the `Content-Type` from `sessionHeaders` and applies it directly to the `RequestSpecBuilder`. - This change ensures that the request uses the exact `Content-Type` provided in the headers, preventing encoding and serialization issues. This update fixes issues where requests with XML or JSON bodies were not being encoded correctly due to the `contentType` defaulting to `ContentType.ANY`.
…/KyrillosNageh/SHAFT_ENGINE into fix/manual-content-type-handling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
============================================
- Coverage 52.67% 52.57% -0.11%
Complexity 1268 1268
============================================
Files 112 112
Lines 9993 9998 +5
Branches 962 964 +2
============================================
- Hits 5264 5256 -8
- Misses 4123 4138 +15
+ Partials 606 604 -2 ☔ View full report in Codecov by Sentry. |
MohabMohie
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697
This PR ensures that the
Content-Typeis set based on the header value if it is not explicitly set by the user.prepareRequestSpecsmethod to check ifcontentTypeis stillContentType.ANY.ContentTypeis not explicitly set by the user, it now retrieves theContent-TypefromsessionHeadersand applies it directly to theRequestSpecBuilder.Content-Typeprovided in the headers, preventing encoding and serialization issues.