Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ensure Content-Type is set based on header value if not explicitly set #1704

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Fix: Ensure Content-Type is set based on header value if not explicitly set #1704

merged 5 commits into from
Aug 17, 2024

Commits on Aug 17, 2024

  1. Fix: Ensure Content-Type is set based on header value if not explicit… 

    …ly set

- Modified the `prepareRequestSpecs` method to check if `contentType` is still `ContentType.ANY`.
- If `ContentType` is not explicitly set by the user, it now retrieves the `Content-Type` from `sessionHeaders` and applies it directly to the `RequestSpecBuilder`.
- This change ensures that the request uses the exact `Content-Type` provided in the headers, preventing encoding and serialization issues.
This update fixes issues where requests with XML or JSON bodies were not being encoded correctly due to the `contentType` defaulting to `ContentType.ANY`.
    Kyrillos Nageh Abdelnour Flamon committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    548b888 View commit details
    Browse the repository at this point in the history

  2. Fix: Ensure Content-Type is set based on header value if not explicit… 

    …ly set
    Kyrillos Nageh Abdelnour Flamon committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    7384425 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/manual-content-type-handling' of https://github.com… 

    …/KyrillosNageh/SHAFT_ENGINE into fix/manual-content-type-handling
    Kyrillos Nageh Abdelnour Flamon committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    124547f View commit details
    Browse the repository at this point in the history

  4. Corrected commit with only necessary changes

    Kyrillos Nageh Abdelnour Flamon committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    6121584 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix/manual-content-type-handling

    @MohabMohie
    MohabMohie authored Aug 17, 2024
    Configuration menu
    Copy the full SHA
    93c6e96 View commit details
    Browse the repository at this point in the history