Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev setup #366

Merged
merged 2 commits into from
Oct 9, 2024
Merged

update dev setup #366

merged 2 commits into from
Oct 9, 2024

Conversation

normanchenn
Copy link
Member

there are a few hiccups when setting up ghostferry locally, so this PR addresses these issues:

  • some modules require go version 1.18
  • use correct dev mysql_client package

@normanchenn normanchenn self-assigned this Oct 8, 2024
@normanchenn normanchenn marked this pull request as ready for review October 8, 2024 17:41
@@ -15,7 +15,7 @@ in stdenv.mkDerivation {
buildInputs = [
env
ruby
go_1_16
go_1_18
mysql57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 should we update this to latest as well or are we ok with 5.7 here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are ok for now

@normanchenn normanchenn merged commit 08b4172 into main Oct 9, 2024
8 of 9 checks passed
@normanchenn normanchenn deleted the norman/dev-update branch October 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants