Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dev setup #366

Merged
merged 2 commits into from
Oct 9, 2024
Merged

update dev setup #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a83d337
upgrade go to 1.18
normanchenn Oct 8, 2024
5acb97f
use mysql_client package
normanchenn Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.16
go-version: 1.18

- name: Starting up MySQL
run: .github/workflows/start-mysql.sh
Expand All @@ -75,7 +75,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: 1.16
go-version: 1.18
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.2
Expand Down
4 changes: 2 additions & 2 deletions dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ env:

up:
- packages:
- [email protected]
- mysql_client
- ruby
- bundler
- go:
version: "1.16"
version: "1.18"
- podman
- custom:
name: Go Dependencies
Expand Down
2 changes: 1 addition & 1 deletion shell.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ in stdenv.mkDerivation {
buildInputs = [
env
ruby
go_1_16
go_1_18
mysql57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 should we update this to latest as well or are we ok with 5.7 here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are ok for now

];
}
Loading