Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Refactored config handling + Added /sf reload #2822

Closed
wants to merge 21 commits into from
Closed

WIP - Refactored config handling + Added /sf reload #2822

wants to merge 21 commits into from

Conversation

TheBusyBiscuit
Copy link
Member

Description

This pull requests moves the config-related stuff from SlimefunRegistry to a dedicated Config Manager.
It also allows some basic reload functionality,, accessible via /sf reload (Many people requested this for a long time).
Note that this is not fully finished though, so not all changes are supported and a lot will still require a restart.

Changes

  • Added /sf reload
  • Added Config Manager to handle our configs
  • All relevant config files have been moved to this Config Manager class
  • All relevant cached data was moved to the Config Manager too

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@TheBusyBiscuit
Some progress
58fe5ac
@TheBusyBiscuit
Merge branch 'master' of https://github.com/Slimefun/Slimefun4.git into
36cceb8 
chore/config-rewrite

Conflicts:
	src/main/java/io/github/thebusybiscuit/slimefun4/core/SlimefunRegistry.java
	src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/VersionsCommand.java
	src/main/java/io/github/thebusybiscuit/slimefun4/implementation/SlimefunPlugin.java
@TheBusyBiscuit
Added /sf reload
dc77c95
@TheBusyBiscuit
Finished reload command
e663251
@TheBusyBiscuit
Merge branch 'master' of https://github.com/Slimefun/Slimefun4.git in…
4a4e9a3 
…to chore/config-rewrite
@TheBusyBiscuit TheBusyBiscuit added the 🎈 Feature This Pull Request adds a new feature. label Feb 13, 2021
@TheBusyBiscuit TheBusyBiscuit requested a review from a team as a code owner February 13, 2021 12:19
@TheBusyBot TheBusyBot added the 🧹 Chores Refactoring / Cleanup. label Feb 13, 2021
@TheBusyBot
Copy link
Collaborator

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Sfiguz7
Sfiguz7 previously approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't spot anything, LGTM

@Sfiguz7 Sfiguz7 self-assigned this Mar 4, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 10, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 10, 2021
Sfiguz7
Sfiguz7 previously approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@Sfiguz7 Sfiguz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the Changelog was edited right? If so, still LGTM

@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 13, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 13, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 14, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 21, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 21, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 25, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 25, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 28, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Mar 28, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Apr 5, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Apr 9, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Apr 10, 2021
@TheBusyBiscuit TheBusyBiscuit removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Apr 10, 2021
@WalshyDev
Copy link
Member

PR looks good aside from the comment I still have open.

@WalshyDev WalshyDev closed this Apr 10, 2021
@WalshyDev WalshyDev reopened this Apr 10, 2021
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Apr 23, 2021
@TheBusyBiscuit TheBusyBiscuit mentioned this pull request Apr 24, 2021
Merged
6 tasks
@TheBusyBiscuit TheBusyBiscuit marked this pull request as draft April 27, 2021 14:27
@TheBusyBiscuit TheBusyBiscuit changed the title Refactored config handling + Added /sf reload WIP - Refactored config handling + Added /sf reload Apr 27, 2021
@TheBusyBiscuit TheBusyBiscuit force-pushed the master branch 2 times, most recently from 7a3bc96 to c48ccc0 Compare May 5, 2021 16:08
@TheBusyBiscuit TheBusyBiscuit mentioned this pull request Jul 11, 2021
Open
@StarWishsama StarWishsama mentioned this pull request Jul 12, 2021
Closed
@J3fftw1 J3fftw1 mentioned this pull request Jul 11, 2023
Closed
7 tasks
@J3fftw1
Copy link
Contributor

J3fftw1 commented Jul 29, 2023

Closing this
Superceding with an up to date branch
#3908

@J3fftw1 J3fftw1 closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalshyDev WalshyDev WalshyDev requested changes

@Sfiguz7 Sfiguz7 Awaiting requested review from Sfiguz7

Assignees

@WalshyDev WalshyDev

@Sfiguz7 Sfiguz7

Labels
🧹 Chores Refactoring / Cleanup. 🎈 Feature This Pull Request adds a new feature. ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheBusyBiscuit @TheBusyBot @WalshyDev @J3fftw1 @Sfiguz7