refactor config handling + added /sf reload #3908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "🧹 Chores" |
J3fftw1
added
the
🎯 Needs testing
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3908/d0b92569
|
|
Kudos, SonarCloud Quality Gate passed! |
Sefiraat
reviewed
Jul 11, 2023
| @@ -14,6 +14,7 @@ | |||
| import javax.annotation.Nullable; | |||
| import javax.annotation.ParametersAreNonnullByDefault; | |||
|
|
|||
| import io.github.bakedlibs.dough.config.Config; | |||
| @@ -6,6 +6,7 @@ | |||
| import javax.annotation.Nonnull; | |||
| import javax.annotation.ParametersAreNonnullByDefault; | |||
|
|
|||
| import com.google.common.base.Preconditions; | |||
There was a problem hiding this comment.
Suggested change
| import com.google.common.base.Preconditions; | |
| import com.google.common.base.Preconditions; | |
| @@ -10,6 +10,7 @@ | |||
| import javax.annotation.Nullable; | |||
| import javax.annotation.ParametersAreNonnullByDefault; | |||
|
|
|||
| import io.github.bakedlibs.dough.config.Config; | |||
6 tasks
variananora
removed
the
🎯 Needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supercedes #2822
This pull requests moves the config-related stuff from SlimefunRegistry to a dedicated Config Manager.
It also allows some basic reload functionality,, accessible via
/sf reload(Many people requested this for a long time).Note that this is not fully finished though, so not all changes are supported and a lot will still require a restart.
Changes
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values