-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a conda based CI workflow #53
base: main
Are you sure you want to change the base?
Conversation
abe3429
to
a9231a4
Compare
Thanks Olivier! It looks great to me. |
@olivier-roussel It seems that only the bindings needs simpleapi, so I would move your changes from a9231a4 in the CMakeLists.txt of the bindings |
14081bc
to
3d26e05
Compare
@alxbilger It seems that the bug comes from one of SoftRobots.Inverse dependency that add |
I suspect the problem comes from SofaPython3. This PR added the dependency to simpleapi in the CMakeLists.txt, but not in |
Indeed, this looks like to be the cause. I will try with a fixed version of SofaPython3. |
Yes what you are saying is correct Alex. I think this is the issue. Olivier and myself stumbled upon a lot of issue of such during the v23.12 release. |
a5504b7
to
4e2a496
Compare
The conda CI using a nightly SofaPython3 integrating the fix you suggested (sofa-framework/SofaPython3#479) successfully passed. Thanks ! |
Adds a workflow for an additionnal CI based on a conda setup. This would enable an easy installation of dependencies required in other PR (such as proxsuite).
Enabled runners:
This should be similar platforms as currently used in our CI, ecxepted there is an additionnal macOS 14 runner for osx arm64 support.
I limited other build to latest python version (3.13) and
Release
build config only, but this can be discussed and adapted.I had a strange bug due to missing library for linking stage on windows only with
Sofa.SimpleApi.lib
. I also already had it locally on ubuntu as well. I tried to fix it with a9231a4, but might not be the right way to do it.