SLVS-1396 Migration wizard: Integrate with the new binding and connection models #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nection away from the UnintrusiveBindingController and into the ConnectedModeMigration class
… path, but instead only if the file exists. The callers do not need to know the name of the file, only if the file exists
…ion.json, which would prevent the new migration to migrate the existing bindings.
hashicorp-vault-sonar-prod
bot
changed the title
vnaskos-sonar
requested changes
Sep 25, 2024
There was a problem hiding this comment.
As discussed, there is
one inconsistency: When there are no credentials on the credentials manager, previously it was succeeding to migrate, but currently it fails.
and one issue: When a user has only legacy projects, the connections.json will not be created and the migration will always be skipped.
…verConnection could not be migrated. If it can not be migrate, due to missing credentials, for example, the old migration should still succeed. The user will just have to manually add the migration
…son does not exist and no bindings in the new binding exist.
|
gabriela-trutan-sonarsource
merged commit ca5fbca
into
feature/new-connected-mode
4 checks passed
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1396
The old migration was working. I just moved the method that was dealing with migrating the ServerConnection for an old binding away from UnintrusiveBindingController and into the ConnectedModeMigration.
Also I am making sure that if the old migration is trying to migrate a server connection and the connections.json does not exist, that we throw an error. The order of the migrations is important.
Additional changes: