Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1396 Migration wizard: Integrate with the new binding and connection models #5700

Merged
merged 9 commits into from
Sep 25, 2024
Merged

SLVS-1396 Migration wizard: Integrate with the new binding and connection models #5700

merged 9 commits into from
Sep 25, 2024

Commits on Sep 23, 2024

  1. SLVS-1396 Rename method

    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ffb0a46 View commit details
    Browse the repository at this point in the history

  2. SLVS-1396 Move method needed only for the migration of the server con… 

    …nection away from the UnintrusiveBindingController and into the ConnectedModeMigration class
    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9698fec View commit details
    Browse the repository at this point in the history

  3. SLVS-1396 Refactor ServerConnectionsRepository to not expose the file… 

    … path, but instead only if the file exists.

The callers do not need to know the name of the file, only if the file exists
    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a653431 View commit details
    Browse the repository at this point in the history

  4. SLVS-1396 Validate that the old migration does not create the connect… 

    …ion.json, which would prevent the new migration to migrate the existing bindings.
    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    08a3d45 View commit details
    Browse the repository at this point in the history

  5. SLVS-1396 Remove not needed white space

    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c3d8b68 View commit details
    Browse the repository at this point in the history

  6. SLVS-1396 Remove no longer needed field.

    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f0a23a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. SLVS-1396 Ensure old migration succeeds even if the corresponding Ser… 

    …verConnection could not be migrated.

If it can not be migrate, due to missing credentials, for example, the old migration should still succeed. The user will just have to manually add the migration
    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6d6c53f View commit details
    Browse the repository at this point in the history

  2. SLVS-1396 Make sure serverConnection is migrated if the connections.j… 

    …son does not exist and no bindings in the new binding exist.
    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5e49a4b View commit details
    Browse the repository at this point in the history

  3. SLVS-1396 Rename method

    @gabriela-trutan-sonarsource
    gabriela-trutan-sonarsource committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    51a2485 View commit details
    Browse the repository at this point in the history