Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Reduce varchar cast inside date/datetime cast #56318

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

kaijianding
Copy link
Contributor

Why I'm doing:

pt is datetime type

SELECT  COUNT(*)
FROM test_tbl
WHERE date_format(cast(cast(pt as varchar) as Datetime), '%Y-%m-%d') between '2024-12-31' and '2025-02-04'

Some generated sql can't do partition prune.

What I'm doing:

rewrite to final sql

SELECT  COUNT(*)
FROM test_tbl
WHERE date_format(pt, '%Y-%m-%d') between '2024-12-31' and '2025-02-04'

reduce the cast pt as varchar when it is inside cast as datetime when pt is date/datetime type

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: kaijian.ding <[email protected]>
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 8 / 8 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/scalar/ReduceCastRule.java 8 8 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit d323948 into StarRocks:main Feb 27, 2025
54 checks passed
Copy link

@Mergifyio backport branch-3.3

Copy link

@Mergifyio backport branch-3.4

Copy link
Contributor

mergify bot commented Feb 27, 2025

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Feb 27, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 27, 2025
mergify bot pushed a commit that referenced this pull request Feb 27, 2025
@kaijianding kaijianding deleted the reduce_varchar_cast branch February 27, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants