Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Reduce varchar cast inside date/datetime cast (backport #56318) #56367

Open
wants to merge 1 commit into
base: branch-3.3
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2025

Why I'm doing:

pt is datetime type

SELECT  COUNT(*)
FROM test_tbl
WHERE date_format(cast(cast(pt as varchar) as Datetime), '%Y-%m-%d') between '2024-12-31' and '2025-02-04'

Some generated sql can't do partition prune.

What I'm doing:

rewrite to final sql

SELECT  COUNT(*)
FROM test_tbl
WHERE date_format(pt, '%Y-%m-%d') between '2024-12-31' and '2025-02-04'

reduce the cast pt as varchar when it is inside cast as datetime when pt is date/datetime type

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant