course management data-providers refactor #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1137.test.live.mm.rbg.tum.de in a few minutes. Logins
|
mono424
changed the title
mono424
requested review from
joschahenningsen,
MatthiasReumann and
alexanderstephan
MatthiasReumann
requested changes
Sep 12, 2023
MatthiasReumann
requested changes
Sep 14, 2023
thanks for the ping! Should have tested better, |
|
@joschahenningsen regarding the size of the pr do you want to take a look first before I merge or can I just go ahead and merge it? |
joschahenningsen
approved these changes
Sep 20, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* started wit hrefactor of course management * add dao & route * update route * started wit hfetching * Add changeset abstraction * cleanup file * remove get all streams again, as there is AdminJson method * Its rendering * further dev :S * added some directive * little fixes * ... * ... no idea... * right path i guess * changeset working except video sections * fix discard files * save from laptop * Add changeset doku * make private works like charm * changing works pretty well * add video upload * add series update * ported transcoding * add readme and lecture hall select * more description * simplified lecture hall set * linter * more fixes * :) * add attachments * :) * Impl. Feedback * fix delete lecture * reenable page reload on create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, the course management relies on Go generated template data. This means we need page reloads
and also it is not good practice to have backend and frontend entangled in that way. Further, much very specific code is used to handle the course management tasks, that could be abstracted in cleaner ways.
Description
This PR untangles backend and frontend by using data-providers that are introduced earlier and are already used for data-sections and other parts of the app. This gives a standardized abstraction to handle the lecture's client side.
Also, this will prevent useless page reloads and give a better standardized and app-global API to create new lectures, fetch or update them.
Steps for Testing
Screenshots
Way shorter UI specific code (edit-course.ts):