Nina and Joannas Movie project #314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tv series
EvaSjoholm
reviewed
Apr 8, 2023
There was a problem hiding this comment.
This is such a great project both code wise and design/stretch goal focused.
It was easy to follow, clean components, adding a CSS file for movie design was a good structure due to media query also being added.
I don't have any inputs for changes, Nina and Joanna you did a very good job at this! And reached stretch goal and great design. Well done!
| @@ -0,0 +1,44 @@ | |||
| /* eslint-disable jsx-a11y/no-static-element-interactions */ | |||
There was a problem hiding this comment.
Very clean component and easy to follow/read. Big ups!
| return ( | ||
| <div className="loader-container" style={{ display: 'flex', padding: 20, marginTop: 100, flexDirection: 'column', alignItems: 'center' }}> | ||
| <div style={{ display: 'flex', padding: 20 }}> | ||
| <Spinner animation="border" variant="light" /> <br /> |
There was a problem hiding this comment.
Creative adding with som animations to the website!
| @@ -0,0 +1,145 @@ | |||
| /***** mobile first *****/ | |||
There was a problem hiding this comment.
Clean CSS too, good structure to follow and read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://movie-night-tonight.netlify.app/