Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nina and Joannas Movie project #314

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
9413efc
first in
NinaWald Mar 28, 2023
ff867d9
css and compound not found
NinaWald Mar 28, 2023
1446d10
css
NinaWald Mar 28, 2023
78fdf9a
adding fixes
NinaWald Mar 28, 2023
0cc268c
Added a basic header with navlinks
Joanna-Philips Mar 29, 2023
7ee62da
Added upcoming movies page
Joanna-Philips Mar 29, 2023
ea77725
Minor chnages to names
Joanna-Philips Mar 29, 2023
d60d924
Merge pull request #1 from NinaWald/header
Joanna-Philips Mar 29, 2023
a09d5fd
Added tv-series page & details but has bugs
Joanna-Philips Mar 29, 2023
7dc33fb
Fixed tv series link bug
Joanna-Philips Mar 30, 2023
96bfe16
Reverted to original className
Joanna-Philips Mar 30, 2023
484811e
Merge pull request #2 from NinaWald/tv-series
Joanna-Philips Mar 30, 2023
cb9414b
Created loader component
Joanna-Philips Mar 30, 2023
c0ffdb5
Implemented Loader in all pages
Joanna-Philips Mar 30, 2023
f39c612
Merge pull request #3 from NinaWald/loader
Joanna-Philips Mar 30, 2023
85b1346
css
NinaWald Mar 30, 2023
cc5c82d
Co-authored-by: Joanna Philips <[email protected]>
NinaWald Mar 30, 2023
48a68ca
css
NinaWald Mar 30, 2023
300fa49
added responsive grid
NinaWald Mar 30, 2023
65f045c
worked on responsive css header issues button
NinaWald Mar 30, 2023
5425394
Added classname to back button on tvdetails
Joanna-Philips Mar 31, 2023
40b95b5
Added section title classes and changed colour
Joanna-Philips Mar 31, 2023
ef5481b
Added button and image classes to tvdetails
Joanna-Philips Mar 31, 2023
9c7572d
Added Logo container and minor fixes on tvdetails
Joanna-Philips Mar 31, 2023
06a5d6e
Positioned header out of wrapper and fixed position
Joanna-Philips Mar 31, 2023
5ab8329
Styled navlinks
Joanna-Philips Mar 31, 2023
5be88a8
Added BackButton component
Joanna-Philips Mar 31, 2023
833a0d2
Added favicon
Joanna-Philips Mar 31, 2023
ed14911
Minor change to button
Joanna-Philips Mar 31, 2023
65f2004
Styling changes to Loader
Joanna-Philips Mar 31, 2023
0686419
Made navbar responsive
Joanna-Philips Mar 31, 2023
d226bba
minor changes
NinaWald Mar 31, 2023
280ed99
Merge branch 'master' of https://github.com/NinaWald/project-movies
NinaWald Mar 31, 2023
2c44ffc
Fixed navbar positioning
Joanna-Philips Mar 31, 2023
9257203
Merge branch 'master' of https://github.com/NinaWald/project-movies
NinaWald Mar 31, 2023
6a027ae
Updated README
Joanna-Philips Apr 1, 2023
f8818da
change mobile grid to 2
NinaWald Apr 1, 2023
74b4ade
readme
NinaWald Apr 1, 2023
d9d2efb
name-change test
Joanna-Philips May 5, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
# Project Movies

Replace this readme with your own information about your project.

Start by briefly describing the assignment in a sentence or two. Keep it short and to the point.
The main focus of this project was using routes in React.
We used APIs to fetch various movie and tv show collections to display on multiple pages with the help of useState, useEffect, Navigation Links and Routes.
This project was done in collaboration - by Nina Waldreus & Joanna Philips.

## The problem

Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next?
First we sketched out the pages, components and the states we would need for each of them.
Next we implemented each page connecting them through routes and navigation links.
When faced with problems we turned for help to Stackoverflow, Google and other team members.
Also used ChatGPT for support.
Improvements for the future would be to make the information richer by using more endpoints from the API.

## View it live

Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about.
Deployed site: https://movie-night-tonight.netlify.app/


## Image credits
https://www.flaticon.com/free-icons/back-button Back button icons created by icon_small - Flaticon
https://www.flaticon.com/free-icons/popcorn Popcorn icons created by Freepik - Flaticon
https://www.flaticon.com/free-icons/menu Menu icons created by Febrian Hidayat - Flaticon
4 changes: 4 additions & 0 deletions code/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
"allowSingleLine": true
}
],
"linebreak-style":[
"off",
"unix"
],
"comma-dangle": [
"error",
"never"
Expand Down
Loading