feat: add python portable version for windows #37
Conversation
There was a problem hiding this comment.
Thank you but we need to have the proper function added in the update-resources.sh file so that those pyexe are automatically updated and added when the pipeline runs (or when someone runs it manually)
|
Sure sorry. Currently I pinned the released to v18. There hasn't been any update since 2019. Is it ok for you ? The version will probably change if there's a new release and it isn't necessarly what we want. |
update-resources.sh
Outdated
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py27-64.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py27.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py35-64.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py35.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py36-64.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py36.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py37-64.exe" | ||
| wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py37.exe" |
There was a problem hiding this comment.
You're overwriting pyexe at every line
Also, the links are broken, you inverted v18 and download
In my opinion the files are too heavy, we shouldn't install them all. Let's keep py37-64 only
Finally, we should probably make this dynamic to avoid having to update the tag every now and then.
In conclusion, we should probably replace the whole block with the following command (and remove the chkks command)
wget -O ./windows/pyexe_37_64bits.exe "https://github.com/manthey/pyexe/releases/latest/py37.exe"There was a problem hiding this comment.
It isn't possible to retrieve a specific asset in the latest version with a single link. However it is possible with multiple command. Is it ok for you ?
Also there hasn't been any update on the repo in 6 years, I think that if there's an update, it will only be for new python version and python 3.7 could be remove, so it's safer to keep a pinned version.
Hello,
This respond to the issue #5 that asked for python from (pyexe)[https://github.com/manthey/pyexe/releases/tag/v18]. Since it might be usefull to have different version of python, I add them all.