Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python portable version for windows #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions update-resources.sh
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ function add_peass() {
add-to-list "PEASS-ng,https://github.com/carlospolop/PEASS-ng,Privilege Escalation Awesome Scripts SUITE"
}


function add_linux_smart_enumeration() {
info "Downloading Linux Smart Enumeration"
chkfs "./linux/"
Expand Down Expand Up @@ -304,6 +305,20 @@ function add_ligolo-ng() {
add-to-list "ligolo-ng,https://github.com/nicocha30/ligolo-ng,Advanced yet simple tunneling/pivoting tool that uses a TUN interface"
}

function add_pyexe() {
info "Downloading Pyexe"
chkfs "./windows/pyexe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py27-64.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py27.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py35-64.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py35.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py36-64.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py36.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py37-64.exe"
wget -O ./windows/pyexe "https://github.com/manthey/pyexe/releases/v18/download/py37.exe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're overwriting pyexe at every line
Also, the links are broken, you inverted v18 and download
In my opinion the files are too heavy, we shouldn't install them all. Let's keep py37-64 only
Finally, we should probably make this dynamic to avoid having to update the tag every now and then.
In conclusion, we should probably replace the whole block with the following command (and remove the chkks command)

wget -O ./windows/pyexe_37_64bits.exe "https://github.com/manthey/pyexe/releases/latest/py37.exe"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't possible to retrieve a specific asset in the latest version with a single link. However it is possible with multiple command. Is it ok for you ?
Also there hasn't been any update on the repo in 6 years, I think that if there's an update, it will only be for new python version and python 3.7 could be remove, so it's safer to keep a pinned version.

add-to-list "pyexe,https://github.com/manthey/pyexe,Create a single Windows executable for python 2.7, 3.5, 3.6, 3.7"
noahfraiture marked this conversation as resolved.
Show resolved Hide resolved
}

# Package dedicated to the download of resources
function add_resources() {
add_sysinternals
Expand All @@ -330,6 +345,7 @@ function add_resources() {
add_chisel
add_winpwn
add_ligolo-ng
add_pyexe
update_submodules
}

Expand Down