changing to imgui sdl #9

sumofat · 2021-12-08T09:20:40Z

Switch examples to the odin's native vendor libraries

ThisDevDane · 2021-12-08T09:47:13Z

impl/sdl/sdl.odin

-    sdl.get_window_size(window, &w, &h);
-    if sdl.get_window_flags(window) & u32(sdl.Window_Flags.Minimized) != 0 {
+    sdl.GetWindowSize(window, &w, &h);
+    if sdl.GetWindowFlags(window) & u32(sdl.WindowFlags.MINIMIZED) == 0 {


Now I suck at bit operations but changing the condition from != to == should be wrong?

This "appears to work" but I think it's actually because WindowFlags.MINIMIZED == 6 when the mask should be 1 << 6.

WindowFlag is the enum, WindowFlags (with an s) is the bit_set of WindowFlag. If GetWindowFlags returned WindowFlags you would expect .MINIMIZED in sdl.GetWindowFlags(window) to work here. So maybe for the time being it can just be casted?

ThisDevDane · 2021-12-08T09:48:12Z

impl/opengl/opengl.odin

@@ -249,7 +249,7 @@ setup_imgui_shaders :: proc() -> u32 {

    ok: i32;
    gl.GetProgramiv(program_h, gl.LINK_STATUS, &ok);
-    if ok != gl.TRUE {
+    if ok != 1/*i32(gl.TRUE)*/ {


Just remove the comments

ThisDevDane · 2021-12-08T09:48:20Z

impl/opengl/opengl.odin

    gl.ShaderSource(h, 1, &data, nil);
    gl.CompileShader(h);
    ok: i32;
    gl.GetShaderiv(h, gl.COMPILE_STATUS, &ok);
-    if ok != gl.TRUE {
+    if ok != 1/*gl.TRUE*/ {


Just remove the comments

ThisDevDane · 2021-12-08T09:49:17Z

impl/opengl/opengl.odin

-    gl.VertexAttribPointer(u32(state.attrib_vtx_pos),   2, gl.FLOAT,         gl.FALSE, size_of(imgui.Draw_Vert), rawptr(offset_of(imgui.Draw_Vert, pos)));
-    gl.VertexAttribPointer(u32(state.attrib_vtx_uv),    2, gl.FLOAT,         gl.FALSE, size_of(imgui.Draw_Vert), rawptr(offset_of(imgui.Draw_Vert, uv)));
-    gl.VertexAttribPointer(u32(state.attrib_vtx_color), 4, gl.UNSIGNED_BYTE, gl.TRUE,  size_of(imgui.Draw_Vert), rawptr(offset_of(imgui.Draw_Vert, col)));
+    gl.VertexAttribPointer(u32(state.attrib_vtx_pos),   2, gl.FLOAT,         gl.FALSE, size_of(imgui.Draw_Vert), uintptr(rawptr(offset_of(imgui.Draw_Vert, pos))));


I can't remember if offset_of doesn't already just output a uintptr or maybe can be directly cast to one?

Ldash4 · 2022-01-18T16:48:35Z

impl/sdl/sdl.odin

+    io.key_map[imgui.Key.Space]       = i32(sdl.Scancode.SPACE);
+    io.key_map[imgui.Key.Enter]       = i32(sdl.Scancode.RETURN);
+    io.key_map[imgui.Key.Escape]      = i32(sdl.Scancode.ESCAPE);
+    io.key_map[imgui.Key.KeyPadEnter] = i32(sdl.Scancode.KP_ENTER);


For the enums in this file, the package and enum name could be elided.

sumofat · 2022-01-26T01:49:36Z

I just now notice that you guys have been reviewing this. Somehow missed it.
I will implement your guys suggestions in due time. Thanks!

…or:glfw, and vendor:opengl.

sumofat · 2022-04-25T02:04:01Z

Just I revistd this to get my osx working with odin-imgui and I fixed a bunch of errors. I also noticed on OSX there is a huge issue where it simply wont work out of the box because shaders require a version but you might chose a different version when starting up the context.

I had to setup shader error logging to finally figure what was causing my opengl to error out on osx.

So... I think that needs to be addressed honestly. Perhaps Ill just note it somewhere.

fixes for super button in sdlodin

…ix_vendor # Conflicts: # impl/opengl/opengl.odin # impl/sdl/sdl.odin

now up to spec with the newest release of odin vendor

Fix vendor

…endor

sumofat · 2022-05-01T03:11:27Z

@ThisDrunkDane @Ldash4 @hstormo @sduman Please review these changes that I have implemented!!

AaronGlazer · 2022-05-01T03:29:28Z

impl/sdl/sdl.odin

+    io.mouse_down[0] = state.mouse_down[0] || (buttons & u32(sdl.BUTTON_LEFT))   != 0;
+    io.mouse_down[1] = state.mouse_down[1] || (buttons & u32(sdl.BUTTON_RIGHT))  != 0;
+    io.mouse_down[2] = state.mouse_down[2] || (buttons & u32(sdl.BUTTON_MIDDLE)) != 0;


In testing I found this to be incorrect, this needs to be changed to BUTTON_LMASK, BUTTON_RMASK and BUTTON_MMASK.

sumofat · 2022-05-06T21:03:36Z

Bump

Adds example for using multiple fonts in imgui.

Adds helper function for loading in a font with opengl.

# Conflicts: # foreign.odin # impl/opengl/opengl.odin

dimsuz · 2022-07-24T19:24:53Z

examples/sdl_opengl/main.odin

+//                        if is_key_down(e, .Escape) {
+//                            qe := sdl.Event{};
+//                            qe.type = .Quit;
+//                            sdl.push_event(&qe);
                        }


This line needs to be commented out too, otherwise it introduces syntax errors.

(while I also not sure that this "commenting out" actually should be included in the PR, perhaps these are some forgotten "debug" changes.

changing to imgui sdl

736d8a1

ThisDevDane reviewed Dec 8, 2021

View reviewed changes

Ldash4 reviewed Jan 18, 2022

View reviewed changes

NoahR02 and others added 7 commits April 7, 2022 02:39

Adds linux support. Replaces shared:glfw, and shared:opengl with vend…

5e41a04

…or:glfw, and vendor:opengl.

Minor changes.

03f0a99

Minor changes.

bb2697b

Casts 'ok' to a bool and compares it with gl.TRUE.

12d9587

Replaces .so with .a.

94400ec

aaa

c0a254d

now compiles and runs ok

ea83356

sumofat and others added 18 commits April 26, 2022 18:50

fixes to make this venderized and less bugggy

26a53e6

add dylib temp

50edfbd

fixes for super button in sdlodin

Merge branch 'vendor' of https://github.com/sumofat/odin-imgui into f…

9cb44b7

…ix_vendor # Conflicts: # impl/opengl/opengl.odin # impl/sdl/sdl.odin

fixed super for mac

7ad5b38

added japanese font support new fonts etc..

97dd1c8

Fixes syntax error.

71a75b0

Update README.md

81e574b

removed comments

3973940

Fixed quite a few errors

1e91a22

now up to spec with the newest release of odin vendor

Merge pull request #1 from sumofat/fix_vendor

18dd69c

Fix vendor

shouldnt put these personal font changes here

49e5e15

Merge remote-tracking branch 'myfork/vendor' into fix_vendor

7a8824e

Merge pull request #2 from sumofat/fix_vendor

1f76220

Fix vendor

fixed font error other minor changes

02979a4

Merge branch 'vendor' of https://github.com/sumofat/odin-imgui into v…

451eda2

…endor

dont need this comment

c1099a7

fixed with minimzied == true pattern for readability

f19413c

elided enum references

ffd4ccf

sumofat marked this pull request as ready for review May 1, 2022 03:10

AaronGlazer reviewed May 1, 2022

View reviewed changes

sumofat added 4 commits May 1, 2022 12:46

Changed to use the Masks instead

ac79b68

Changed to use the mask instead

aa7508c

removed unneeded

13071d0

reinserted

7cd4ef8

sumofat mentioned this pull request May 2, 2022

Adds linux support. Replaces shared:glfw, and shared:opengl with vendor:glfw, and vendor:opengl. #12

Closed

NoahR02 and others added 4 commits May 7, 2022 22:03

Adds helper function for loading in a font with opengl.

c420998

Adds example for using multiple fonts in imgui.

Merge pull request #1 from NoahR02/feature/add-odin-font-example

20c1f64

Adds helper function for loading in a font with opengl.

Merge remote-tracking branch 'noah/master' into vendor

54a1296

# Conflicts: # foreign.odin # impl/opengl/opengl.odin

removed fmt and win32 imports and a few others

02fccd1

dimsuz reviewed Jul 24, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

changing to imgui sdl #9

changing to imgui sdl #9

sumofat commented Dec 8, 2021

ThisDevDane Dec 8, 2021

AaronGlazer May 1, 2022 •

edited

Loading

ThisDevDane Dec 8, 2021

ThisDevDane Dec 8, 2021

ThisDevDane Dec 8, 2021

Ldash4 Jan 18, 2022

sumofat commented Jan 26, 2022

sumofat commented Apr 25, 2022

sumofat commented May 1, 2022

AaronGlazer May 1, 2022

sumofat commented May 6, 2022

dimsuz Jul 24, 2022

changing to imgui sdl #9

Are you sure you want to change the base?

changing to imgui sdl #9

Conversation

sumofat commented Dec 8, 2021

ThisDevDane Dec 8, 2021

Choose a reason for hiding this comment

AaronGlazer May 1, 2022 • edited Loading

Choose a reason for hiding this comment

ThisDevDane Dec 8, 2021

Choose a reason for hiding this comment

ThisDevDane Dec 8, 2021

Choose a reason for hiding this comment

ThisDevDane Dec 8, 2021

Choose a reason for hiding this comment

Ldash4 Jan 18, 2022

Choose a reason for hiding this comment

sumofat commented Jan 26, 2022

sumofat commented Apr 25, 2022

sumofat commented May 1, 2022

AaronGlazer May 1, 2022

Choose a reason for hiding this comment

sumofat commented May 6, 2022

dimsuz Jul 24, 2022

Choose a reason for hiding this comment

AaronGlazer May 1, 2022 •

edited

Loading