Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate recorded snapshots in Swift workflow #311

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

tinder-garricnahapetian
Copy link
Contributor

No description provided.

Copy link
Collaborator

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this new workflow and instead add the following steps to the end of the Swift workflow. Thank you.

  • Delete snapshots
  • Test renamed to Record snapshots
  • Detect superfluous snapshots renamed to Validate recorded snapshots

.github/workflows/superfluous-snapshots.yml Outdated Show resolved Hide resolved
.github/workflows/superfluous-snapshots.yml Outdated Show resolved Hide resolved
.github/workflows/swift.yml Outdated Show resolved Hide resolved
.github/workflows/swift.yml Outdated Show resolved Hide resolved
@tinder-garricnahapetian tinder-garricnahapetian changed the title Add Superfluous Snapshots workflow Validate recorded snapshots in Swift workflow Jan 30, 2024
@tinder-garricnahapetian tinder-garricnahapetian force-pushed the add-superfluous-snapshots-workflow branch from d8d484c to ae5a2e0 Compare January 30, 2024 19:22
tinder-cfuller
tinder-cfuller previously approved these changes Jan 30, 2024
Copy link
Collaborator

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Co-authored-by: Christopher Fuller <[email protected]>
tinder-cfuller
tinder-cfuller previously approved these changes Jan 30, 2024
Copy link
Collaborator

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This reverts commit faf6cc9.
@tinder-garricnahapetian tinder-garricnahapetian merged commit 6e3a810 into main Jan 31, 2024
2 checks passed
@tinder-garricnahapetian tinder-garricnahapetian deleted the add-superfluous-snapshots-workflow branch January 31, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants