Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate recorded snapshots in Swift workflow #311

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Validate recorded snapshots in Swift workflow #311

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e69e97
Add Superfluous Snapshots workflow
tinder-garricnahapetian Jan 27, 2024
28c14b3
Prevent job from exiting on failure
tinder-garricnahapetian Jan 27, 2024
f0bae8d
Match existing workflows
tinder-garricnahapetian Jan 27, 2024
8542a33
Continue on error
tinder-garricnahapetian Jan 27, 2024
5d886ea
Remove temp file
tinder-garricnahapetian Jan 27, 2024
ae5a2e0
Move steps to existing workflow
tinder-garricnahapetian Jan 30, 2024
9a03c6c
Use multiline formatting
tinder-garricnahapetian Jan 30, 2024
faf6cc9
Add temp file
tinder-garricnahapetian Jan 30, 2024
164aa27
Revert "Add temp file"
tinder-garricnahapetian Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,10 @@ jobs:
test-without-building
-scheme "Layout"
-destination "name=$SIMULATOR,OS=latest"
- name: Delete snapshots
run: make delete-snapshots
- name: Record snapshots
run: xcodebuild test-without-building -scheme "Layout" -destination "name=$SIMULATOR,OS=latest"
tinder-garricnahapetian marked this conversation as resolved.
Show resolved Hide resolved
continue-on-error: true
- name: Validate recorded snapshots
run: test -z "$(git status --porcelain)"
Loading