Fix nation deleted message showing when a predeletenationevent iscancelled. #7381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancelled. Not really happy with the implementation of this, as it changes our DataSource pattern to one where only a single removeObject method returns a boolean. The TownUtil change is also not ideal now or before this PR as the Nation can be prevented from being deleted, while still processing a refund. Potential alternative solutions: - Run the message in the DatabaseHandler method, and lose the custom deleted by admin message sent to the admin who deleted the nation. - Run the PreDeleteNation event before the removeNation(Nation) in order to prevent the TownUtil method being made redundant, and causing issues. Closes #7380.
1 task
LlmDl
added a commit
that referenced
this pull request
Apr 26, 2024
…celled. (#7383) * Fix nation deleted message showing when a predeletenationevent iscancelled. Uses the nation.exists to determine if the removal of the nation was successful or not, and displays messages to match the outcome. Closes #7380. Supercedes #7381. * Remove event handler used in testing. * Fix sending message to the non-existant nation. * Do the same for TownUtil, removing call to sendPrefixedNationMessage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Not really happy with the implementation of this, as it changes our DataSource pattern to one where only a single removeObject method returns a boolean. The TownUtil change is also not ideal now or before this PR as the Nation can be prevented from being deleted, while still processing a refund.
Potential alternative solutions:
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
Closes #7380.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.