Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Slider Height on Font Load. #11

Closed
wants to merge 1 commit into from
Closed

Fix Slider Height on Font Load. #11

wants to merge 1 commit into from

Conversation

imranhsayed
Copy link
Contributor

  • handleResize should be replaced by updateHeight and should be placed outside the condition ( 'ResizeObserver' in window ), else does not work.

@imranhsayed imranhsayed changed the title Update document.fonts.ready on fontload Fix slider height on font load. Dec 7, 2023
@imranhsayed imranhsayed changed the title Fix slider height on font load. Fix Slider Height on Font Load. Dec 7, 2023
@junaidbhura junaidbhura marked this pull request as draft December 12, 2023 02:56
@junaidbhura
Copy link
Contributor

@imranhsayed is this still required?

@junaidbhura junaidbhura closed this Jan 2, 2024
@junaidbhura junaidbhura deleted the fix/resizeheight-on-fontload branch January 2, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaidbhura junaidbhura Awaiting requested review from junaidbhura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imranhsayed @junaidbhura