Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slider Height on Font Load. #11

Closed
wants to merge 1 commit into from
Closed

Fix Slider Height on Font Load. #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/slider/tp-slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,18 @@ export class TPSliderElement extends HTMLElement {
// These are just fallbacks for browsers that don't support ResizeObserver.
// @ts-ignore
window.addEventListener( 'resize', this.handleResize.bind( this ) );
document.fonts.ready.then( () => this.handleResize() );
}

/**
* Add callback when fonts are ready.
*
* We are doing this so that height is slider height is re-calculated
* after the fonts are loaded, otherwise we get incorrect height
* due to default fonts size at initial load.
* This does not work on 'DOMContentLoaded' event.
*/
document.fonts.ready.then( () => this.updateHeight() );

this.addEventListener( 'touchstart', this.handleTouchStart.bind( this ) );
this.addEventListener( 'touchend', this.handleTouchEnd.bind( this ) );
}
Expand Down