Add null checks in SdtTagName #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SdtTagName was throwing lots of exceptions, so I downloaded your code and took a look in debug mode. The ".Element(W.tag)" part was null. I added null checks (via the question marks), and it solved my problem and seems to run quite a bit faster. I did not spend any time trying to understand your code, but if the try/catch is there just for handling nulls, maybe that is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SdtTagName was throwing lots of exceptions, so I downloaded your code and took a look in debug mode. The ".Element(W.tag)" part was null. I added null checks (via the question marks), and it solved my problem and seems to run quite a bit faster. I did not spend any time trying to understand your code, but if the try/catch is there just for handling nulls, maybe that is no longer needed.