Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null checks in SdtTagName #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add null checks in SdtTagName #63

wants to merge 1 commit into from

Commits on Apr 1, 2020

  1. Add null checks in SdtTagName 

    SdtTagName was throwing lots of exceptions, so I downloaded your code and took a look in debug mode.  The ".Element(W.tag)" part was null.  I added null checks (via the question marks), and it solved my problem and seems to run quite a bit faster.  I did not spend any time trying to understand your code, but if the try/catch is there just for handling nulls, maybe that is no longer needed.
    @thomas-taylor
    thomas-taylor authored Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2213822 View commit details
    Browse the repository at this point in the history