Cf anyPoint writer rework to use multiple altNames and timeNames #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d write new method for writing the header of PointFeatureCollections
…riter # Conflicts: # cdm/core/src/main/java/ucar/nc2/ft/point/writer2/WriterCFPointCollection.java
…nd altName arguments
…e extraneous method
mnlerman
changed the title
mnlerman
added
bug
haileyajohnson
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Addresses the netcdf-java side of Unidata/tds#269
need to build lists of the stations, feaature data and middle data for collections of features. Loop over them when writing to include all information about the collection.
Note possible performance improvement: since we're looping, we're trying to add some variables twice which is being caught and raising a warning that the variable already exists. Could check if the variable exists sooner.
Still to do: update TDS code to use new methods that have the altName and timeName (I'm working on this today and next week)
PR Checklist
until ready for review